[quote name='vignot' timestamp='1356000711' post='327684']
thank you for the release. It's working well, plus I learned a few thing by reading your code.
- some of my artists are not matched, or are matched but no summary or profile is fectched. I didn't look at the cause yet.
- my ID3 tags are overriden by album metada from the Album Agent (I checked the Discog one).
So I've added :
accepts_from = ['com.plexapp.agents.localmedia']
In the MusicbrainzAgent(Agent.Album) and put the "Local Media Assets (Albums)" on top.
Anyway, it still doesn't match everything like I would like so I will go on developping my Discogs agent as a primary. Just for fun ;)
A few thing you should improve :
- the summary fetched from Discogs contains some tags like [A=blablabl], they should be stripped off.
- when several artists have the same name, Discogs list them with number.
Exemple : Sublime, Sublime (2), Sublime (3), etc
That's not really nice to keep these names in Plex listing.
"- some of my artists are not matched, or are matched but no summary or profile is fectched. I didn't look at the cause yet."
It uses matching against Musicbrainz.org. If it's not automatching, it's likely because artist name in your ID3 tag is not 100% the same as written on the sites. Because it's set to half the score that resulted from the search. So say if you searched for the artist "Weird Al" Yankovic, it'll get a hit on musicbrainz with Weird Al Yankovic with 100 in score even. But since that's not exactly the same as "Weird Al" Yankovic, it will half the score, so to plex, the score is 50, which is below the 80 score needed to match it automaticly. That means it will need manual matching. Im looking into ways to make that smoother by taking more things into consideration for scoring, but for now, it's kindof low priority as long as manual matching works :)
"- my ID3 tags are overriden by album metada from the Album Agent (I checked the Discog one)."
Indeed they are. The ID3 tags are used ONLY for providing the initial matching. Beyond that, it fetches all data from remote. Im doing that by design but sure, adding local to accept_from should solve that for those that want that. I'll make sure to update the repo with that asap. Thank you.
"- the summary fetched from Discogs contains some tags like [A=blablabl], they should be stripped off."
Yes and no :) I might make that into a setting or something that's off by default. I know that PMC doesnt really handle it so there it looks ugly, but I kindof like having the links in the info myself when viewing it in the browser.
"- when several artists have the same name, Discogs list them with number."
It's not something that can be fixed by me. As an example. If I search the discogs site for the artist Mojo, I get http://www.discogs.com/artist/Mojo+%2811%29 as one of the hits. That's Mojo (11). My agent doesnt use that however, but rather it searches on musicbrainz, where it finds several artists named Mojo, one of which have the disambiguation tag of Dubstep... That's the artist Im looking for, so I select that in the "fix incorrect match" because the auto matching will match against the french rapper named Mojo. Now the agent fetches the information for the Mojo Dubstep artist, and finds that there's a link there to the discogs page. It can now fetch the discogs page and there is sees that the artist name is Mojo (11). Now see the reason it cant be fixed, is because unlike musicbrainz, discogs doesnt actually give ANY sort of information as to if that (11) is because of multiple artists or if it's actually part of the artist name. Stripping that away will result in some artists getting it stripped away incorrectly. Basicly, I would LOVE to fix this... But it's not really something in my hands. I'd love to fix it so information from Last.FM isnt combining artists of the same name as well, but also an issue that's sadly, out of my hands. What you can do to avoid getting problems with it, is that you dont set Discogs as the top agent but rather set Musicbrainz or LastFM there instead. That makes them set the name instead of Discogs, and both those will list the names without such tags added to the names.