@Mitzsch I appreciate your work on this, thanks! It might have been asked recently, but what are we waiting on for this fix to be merged into the latest official MPV release… is this ticket holding it up? Or is this fix not deemed stable enough to be merged?
The trueHD fix needs to be merged in the ffmpeg code base. The fix is not committed to the ffmpeg mailing list by gbooker02 as far as I know. mpv is unrelated, when it comes to the truehd issue. The incompatibility of the latest mpv with Plex htpc is caused by the linked commit, so a custom mpv is now needed anyway.
1 Like
Haven’t built in a few months, tried using ninja mpv-ntruehd today which failed with the following error:
FAILED: packages/shaderc-prefix/src/shaderc-stamp/shaderc-configure /home/vernd/mpv-winbuild-cmake/build64/packages/shaderc-prefix/src/shaderc-stamp/shaderc-configure
cd /home/vernd/mpv-winbuild-cmake/build64/packages/shaderc-prefix/src/shaderc-build && /usr/bin/cmake -P /home/vernd/mpv-winbuild-cmake/build64/packages/shaderc-prefix/src/shaderc-stamp/shaderc-configure-.cmake && /usr/bin/cmake -E touch /home/vernd/mpv-winbuild-cmake/build64/packages/shaderc-prefix/src/shaderc-stamp/shaderc-configure
CMake Error at /home/vernd/mpv-winbuild-cmake/build64/packages/shaderc-prefix/src/shaderc-stamp/shaderc-configure-.cmake:49 (message):
Command failed: 1
pg /home/vernd/mpv-winbuild-cmake/build64/packages/shaderc-prefix/src/shaderc-stamp/shaderc-configure-*.log
Disabling PCH
CMake Error: install(EXPORT “glslang-targets” …) includes target “SPIRV” which requires target “SPIRV-Tools-opt” that is not in any export set.
CMake Warning:
Manually-specified variables were not used by the project:
MINGW_COMPILER_PREFIX
SHADERC_SKIP_SPVC
Could you please take a look at this?
Thanks
Please rebuild from scratch - delete the whole mpv-winbuild folder and start with a fresh clone from github.
Note that one package should now be installed too. =>
pacman -S llvm
The build environment is known to break over time with system updates and other updates.
Roger - Wilco
Still no go. I noticed that there are packages installed on the system for ffmpeg, libplacebo, shaderc, & glslang. Is it possible they are causing a conflict?
Confirmed all additional required packages are installed except gcc-multilib which doesn’t exist in pacman
git gyp mercurial subversion ninja cmake ragel yasm nasm asciidoc enca gperf unzip p7zip clang llvm lld libc++ libc++abi python-pip curl lib32-gcc-libs lib32-glib2 mimalloc ccache
Different error or the same error?
I will need to test on my building env - this however may take some days. (my semester at university just started again…)
Same error.
pg /home/vernd/mpv-winbuild-cmake/build64/packages/shaderc-prefix/src/shaderc-stamp/shaderc-configure-*.log INT ✘
Disabling PCH
CMake Error: install(EXPORT “glslang-targets” …) includes target “SPIRV” which requires target “SPIRV-Tools-opt” that is not in any export set.
CMake Generate step failed. Build files cannot be regenerated correctly.
What is your configure command?
What os are you using?
ninja mpv-ntruehd
Manjaro
However, I think I may have found the issue.
It looks like both the mpv-otruehd.cmake and the mpv-ntruehd.cmake have a
DEPENDS entry for spirv-cross in them. The plex versions don’t have one.
Re-compiling now to check.
Nope - Still fails.
Disabling PCH
CMake Error: install(EXPORT “glslang-targets” …) includes target “SPIRV” which requires target “SPIRV-Tools-opt” that is not in any export set.
CMake Warning:
Manually-specified variables were not used by the project:
MINGW_COMPILER_PREFIX
SHADERC_SKIP_SPVC
CMake Generate step failed. Build files cannot be regenerated correctly.
Should be working now, just merged the one new commit from upstream that fixes building.
Success!!! Build now works. Thanks for the prompt attention.
I would like to use 0.38 so I need to revert that commit? But I can’t revert c678033c1d60b48ae02fbbe4815869b9504a17f6 because that’s from the main branch?
Can we have a github repo with ready to go builds? It’s all very confusing if you are not into building dlls
This commit needs manual by-hand reversion - not that trivial. That is why I have the mpv fork GitHub - mitzsch/mpv at plex-htpc-hdr-patches. There I have reverted the commit.
Can be build by ninja mpv-plex-otruehd/mpv-plex-ntruehd
Its seems however there is a new commit that breaks Plex HTPC again. My personal build from 12.04 works but the build from yesterday crashes Plex HTPC… Will need to have a look at this…
1 Like
Very difficult as far as I understand this, it requires services that cost money - not going to do it.
Yeah I’ve been using your forks for a while now 
I’ve manually reverted commits before and I’ve downloaded 2 of the 3 files necessary. But as you say, this one is not trivial.
Just for reference yesterdays 0.38 mpv upstream build doesn’t crash Plex HTPC it just doesn’t load which is expected. So I would be surprised if your latest fork does crash.
The issue is caused by an openssl commit. Just found it randomly on reddit. This has been fixed already, by reverting the one specific openssl commit.
Its only crashing when loading a (ssl) video. So its not surprising that upstream mpv will not crash, as its not even loading a video.
I did a build today. It tells me that the file was modified on Friday which I suppose is OK. But the performance of Plex HTPC with SVP takes a big performance hit. It’s unusable with my current mpv+SVP configuration while the old mpv-2.dll is OK. There are other issues even with other recent builds but this one is the worst. Not saying it’s your fault, just letting you know
