libSDL source code request

Dev Community Dev/API Corner
1

This a request for current source code/patches/configure used to build the following binaries that are compiled into the Plex binary.



libSDL-osx.a

libSDL_image-osx.a

libSDL-mixer-osx.a

libSDLmain-osx.a



Thank you

Scott

2

Elan is out right now, so it might take a couple days for a reply :slight_smile:

3


Isaac, I think you should change you group status string thingy (that appears under your name in the forums) to "Elan's Answering Machine" :)
4

[http://www.libsdl.org/](http://www.libsdl.org/) and [https://trac.macports.org/browser/trunk/dports/devel/libsdl](https://trac.macports.org/browser/trunk/dports/devel/libsdl). Plex doesn't use any patches other than those from MacPorts.
5

A step by step guide to compiling Plex can be found on our wiki:



http://wiki.plexapp.com/index.php/How_to_Compile

6

@Pundy



Leave a message after the beep!

7


Hate to say it but you are misinformed and need to review the commit history for libSDL binaries ;)

There are additional symbols present in the compiled binaries present in Plex git which are not present in the stock MacPort compiled binaries. This indicates the libSDL source code has been modified and those modifications are not present in the existing patches that exist in Plex git. In addition, byte sizes and checksums of stock compiled MacPort sources binaries do not match those in Plex git.
8

That may be, but none of the Plex builds I've made in the last 6 months have involved any modifications to libSDL. We link statically to the SDL binaries available on the system via MacPorts. They are distributed within the compiled Plex binary, hence are not included in the Git repository.

Perhaps I'm being obtuse, but I don't follow your point. There are no libSDL binaries separate from the static libs included in the executable. These are compiled directly from the publicly available code at MacPorts. Can you not build Plex with the instructions Isaac has posted above?

Maybe you should post links to the relevant commit history, and the results of nm detailing these "missing symbols." Elan might have modified the binaries on his system before generating builds, but I'm not aware, and certainly do not need to to get a working plex build.
9


I'm quite familiar with XCode and the entire build process the main binary and all of the support binaries. However, nether my building of Plex nor your personal builds of Plex is material to my inquiry.

The point is the released Plex binary has symbols present that track back to inside libSDL static binaries which are linked to Plex at build time and they are not present in either the patches/source in the git tree nor the MacPort source code. The GPL license under which you are permitted to use libSDL require modifications to said source code be available to anyone who asks. I'm asking for it and I don't have give any reasons for such an inquiry nor provide proof that modification have occurred.

Since neither of you seem to have access to the complete source code tree used to build the application called Plex, I will need to wait until the head developer returns as he seems to be the only one with complete source code access. Why he has chosen to exclude this information from the other developers of Plex is puzzling for an open source project but that is not my concern. My inquiry only addresses the source code modifications to libSDL.

Thanks
Scott
10

Hey davilla, nice to see you around these parts, welcome :slight_smile:



I had to do a bit of backtracking to see what code we added to SDL and why, as we did go back to vanilla SDL for a long while. It turns out I did need to add one function to help fix the “mouse won’t extend to the edges of the window” problem. This was a during a 10 hour hackathon in which I kept going back and forth between needing changes to SDL and not, which is likely why I forgot to check in a patch along with the libs.



Without further ado, here’s the code from SDL_QuartzEvents.m. If you need anything else or have any questions, please don’t hesitate to contact me via email and I’ll get you sorted out quickly.



Thanks, and have a great day :slight_smile:



// HACK!<br />
void QZ_ChangeWindowSize(int w, int h)<br />
{<br />
  SDL_VideoSurface->w = w;<br />
  SDL_VideoSurface->h = h;<br />
}
11

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.