@gbooker02 I figured it was best to have this in a separate thread.
I’ve done quite a bit more testing with the htpc client for linux with HW decoding and wayland. I’ve been trying to get it to run on wayland natively (with HW decoding hopefully). But every time I try to use the wayland-egl backend for Qt, the app segfaults.
Looking at the code for PMP, and Jellyfin’s fork, this exact behaviour exists there as well. (comparing the logs from the two apps, and some other info, I might be correct in assuming the two apps share quite a lot of code?)
If this code exists in plex-htpc as well, this will likely be the culprit for the bugs on wayland.
I know the Jellyfin fork has solved this issue (and HW decoding on wayland), but I’m guessing you can’t look at their patch due to license incompatibility (or not?, see below). Anyways I hope this helps getting better support for linux
(As an aside, lots of the log lines in plex HTPC are found in PMP as well, indicating much of the source code is identical. Considering that code is licensed under GPLv2, the same code in plex HTPC must also be GPLv2 and you are required to disclose the source upon request?)
Looks like our Qt build is missing QtWayland. Likely it just defaulted to off and went unnoticed. Perhaps we can get it added in when we next build Qt (which is currently blocked on other things).
The GPL is backed by copyright and is a license under which the copyright holders grant to others. The copyright holders are free to re-license at will (a process I went through with Perian we we re-licensed it from GPL → LPGL).
Yup. However, irregardless of this, the issue outlined in the op will still cause it to crash. I use QtWayland in the arch build, which works just fine (qt correctly loads and uses the Wayland backend).
I applied the patches from jellyfins fork to PMP, which has the exact same issue as this one. And after applying those patches PMP runs on Wayland with HW decoding . So if my assumption that you have the same player code initializing libmpv, you will need to apply those patches (or fix the issue yourself depending on license conflict).
The GPL is backed by copyright and is a license under which the copyright holders grant to others. The copyright holders are free to re-license at will
Right, so plex HTPC is not GPL and the aforementioned code has been re-licensed? I’m just wondering out of curiosity
Hey! Just wanted to ask if there has been any progress on this? (Regarding the inclusion of QtWayland and fixing the MPV initialization to not hard default to X11, as well as enabling MPV hw decoding for the wayland context)
As far as I’m aware, the issues has not been worked on for the recent releases (1.17 latest as of this post). Is it in the roadmap for some future release? It would be awesome if this works for the upcoming plex for linux release as well!