@p376em really cool I’ll test as well.
Looking through a diff all I see as actually different (excluding all the test lines) is:
- return self.isSupported and (self.decisionsCodes["mdeDecision"] > -1 or requireItem and not self.item)
+ return self.isSupported and not (self.decisionsCodes["mdeDecision"] == -1 or not self.item)
in lib/_included_packages/plexnet/plexplayer.py
That is becuase if transcoding is required it returns something that it cant find becuase if you debug the xml records if it requires transcoding you get the xml below but it dosnt contain the mdeDecisions unless it directPlay
<MediaContainer size="1" allowSync="1" directPlayDecisionCode="3000" directPlayDecisionText="App cannot direct play this item. Direct play is disabled." generalDecisionCode="1001" generalDecisionText="Direct play not available; Conversion OK." identifier="com.plexapp.plugins.library" librarySectionID="4" librarySectionTitle="Movies" librarySectionUUID="a420b9d8-2f92-4b7b-9f90-ceca1c2fb2a3" mediaTagPrefix="/system/bundle/media/flags/" mediaTagVersion="1582835515" transcodeDecisionCode="1001" transcodeDecisionText="Direct play not available; Conversion OK.">
@p376em nice find!
For anyone looking for a clean patch then
https://github.com/splitice/plex-for-kodi/commit/b5edb495de92400060d1962f8eda6bb894a67f9c.patch
Tested both, neither seems to work on the few files I know that fail.
@p376em want an invite to a massive plex server? I’ll happily provide one to you permanently if you can investigate…
The two cases that seem to result in failures are both files that would force transcoding. One is a 4k file that needs to be transcoded to 1080p (different bug bug PlexForKodi can’t resolution switch for some reason) and the other has audio transcoding (2 channel -> 5.1)
that would be great as im trying to find a permanent fix for the issue the other fix was a tempoary patch until i could find the root cause of the issue
p376em your plex name? or pm me your email and I’ll add you.
I need to learn a little more python to understand it all, I knew what was causing the problem, just couldn’t figure out where it was. Why don’t we all work from the same github page.
+1 good idea
Three separate fixes, one of which was @p376em’s
Please note this disables MKV transcoding (MKV will use HLS instead) as MKV streaming is where the change is. I don’t know enough about plex’s (undocumented?) streaming protocols to fix buildTranscodeMkv
Really promising to see work being done on a fantastic addon that doesn’t deserve to be deprecated. You guys rock.
Can confirm this worked for me as well. I’m able to transcode without issue once I downgrade Plex Media Server to 1.18.5.2309. Hopefully an update to Plex For Kodi fixes it, but this temporary fix will suffice for now until the devs bother to actually do something.
btw … uninstalling PLEX does NOT mean you loose the configuration of your server, your shares, settings etc. . If you uninstall Plex in Windows OS , all your Data stays on your harddisk (AppData … hidden Folder). You uninstall only the “programm”, the executables + corresponding files. So this solution, downgrading to 1.18.5. - is pretty problem & effort free.
My server is running Ubuntu server, I also run the plexupdate script from github so all my updates happen automatically. I cant be bothered to alter that. Literally the android app and the kodi addon are the broken players. I tried browsers, xbox one, crapple devices and they all work fine.
This is fixed improperly fixed here.
I have a fix that should work. Please let me know if it fixes the issue for you. script.plex-0.1.7a4.zip
If all is well with this fix, I’ll PR this build to the Kodi official repo (this includes some other pending updates)
Thanks!
@ruuk Installed on FireTV Stick 4k. Transcoding works
Is this for Kodi 19 only?
@christianc18 panni is working on Kodi19 compatibility. The other fixes here are for Kodi18
I’ve got immediate branches for both with the proper fixes available.
Expect more work towards official/stable soon 
I hope u and ruuk can work hand in hand . So we dont need to look at different githubs to get the newest :), also Auto Update via Kodi could work then
Thansk for ur work
