I have 2 pull requests open at the moment:
https://github.com/plexinc-plugins/Services.bundle/pull/678
https://github.com/plexinc-plugins/Services.bundle/pull/679
Is there anything I need to do to have them looked at?
I have 2 pull requests open at the moment:
https://github.com/plexinc-plugins/Services.bundle/pull/678
https://github.com/plexinc-plugins/Services.bundle/pull/679
Is there anything I need to do to have them looked at?
Sander (the administrator of the Channel Directory) is aware of your pull requests and just needs to review the code before merging them. He often has a fair bit on his plate so, don't be surprised if it takes a while. That being said, a gentle reminder such as this post is not a bad idea if your PRs have been open a while without any activity. Thanks for contributing.
Thanks Mike (and Sander) - with other software, I can usually use the stuff I write locally while it gets reviewed, but with URL services, changes either get overwritten (for existing services) or are ignored (for new services, since queuing relies on the service existing on a central server). I hope this can be improved in the future (for developers; the experience for end users is great as it is).
Thanks again!
If you want changes you have made to an existing URL service to not be updated by Plex, you can add a Developement line in the Services.bundle Info.plist. This will keep Plex from updating the Services.bundle. The only problem with this is you will not get updates that are made to other URL services in the Services.bundle while this is enabled.
PlexPluginDevMode 1
You can also add the above code to a individual channel bundles Info.plist so it will not be updated by Plex. (Most people use a symlinks, but for me using Window 7, Plex updates will delete any code in my symlink as well so I use the above code instead)
If it is a URL service for a new channel, you make it part of your new channel bundle. You create a Services folder and put the ServiceInfo.plist there with a folder for the new URL service. Since a new channel will not be updated or removed when Plex does its daily updates, your new URL service will remain intact.
Here is a link to an old version of the Lifetime channel before its URL service was added to the Services.bundle. It shows the structure of folders and coding used when you create a new channel bundle that includes a URL service - https://github.com/shopgirl284/Lifetime.bundle/tree/99f7b1e88083cdd7bb6534e2b74b80c053131107
This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.