PM4K / PlexMod for Kodi (18, 19, 20, 21, 22+)

Plex Players Streaming Devices
, , , , ,
2587

Maybe a temporary network hickup that we didn’t properly handle. Please keep an eye on this!

2588

0.7.9-beta16.6: script.plexmod.zip (2.8 MB)

Temporary Changelog:

  • Settings: Move “Stop video playback on idle after” and “Stop video playback on screensaver” settings to Video Player tab
  • Settings: Add CONTEXT_MENU to clear bound home button to description
  • Player/PlaybackState: Avoid using the player’s current time when reporting a stopped state via the tick() method; might fix resume issues on CoreELEC when switching audio streams that need transcoding; add logging
  • Player/PlaybackState: Only store progress for episode view if updatePlaybackState has accepted and sent our new timestamp
  • Player/PlaybackState: Allow forcing a timestamp
  • Core/Cache/Settings: Disallow writing (and showing) cache settings from within the plugin when installed from the official Kodi repository and we don’t have the modern API
  • Library/Music: Support Tracks as type on Music libraries; partially fixes #133; should fix #132

Edit: Reuploaded zip (04:01 CEST)

Edit 2: Reuploaded zip (cosmetic, showed 0.7.9-beta16.5 instead of 16.6; 12:35 CEST)

Edit: In theory, this could break resume handling (just because I’ve touched it). It shouldn’t, though (tested), but please report back.

3 Likes
2589

If I’m not wrong, the downloaded file still shows 0.7.9-beta16.5 instead of 0.7.9-beta16.6.

2590

You’re not, my fault (just cosmetic, the changes were in there; reuploaded zip).

1 Like
2592

When starting this version and I select the home user to use, it boots back to the kodi screen. even tried it with the deleted advancedsettings.xml.

2593

Oh OK. You can delete the plex server and xml resources part in your addon_data/script.plexmod/settings.xml, that should fix it.

I’ll release a fix later today

Edit: removing the zip for now.

2594

Ah. You have a manual server defined. I’ll fix that later. Everyone else: you can use the zip if you’ve already downloaded it.

2595

0.7.9-beta17 re-release: script.plexmod.zip (2.8 MB)

Thanks for that hint, I knew that, but didn’t apply that knowledge somehow.

I’ve found out that the https://plex.tv/pms/resources response contains the attribute dnsRebindingProtection in a server resource. This attribute seems to be accurate. I’m not sure yet, how this is determined. , but I guess the public address is matched against the server’s public address. Need to confirm with the Plex guys.

With 0.7.9-beta17 we now only handle plex.direct hosts for DNS rebind protection if that flag is set for a server and publicAddressMatches=1 (meaning that the client’s public IP is the same as the server’s; e.g.: local). Might break things, might not - please test!

Temporary Changelog:

  • Core/DNS: Only handle hosts for servers with dnsRebindingProtection=1 in plex.tv/pms/resources
  • Core/DNS: Check for dnsRebindingProtection and publicAddressMatches
  • AddonSettings: Add setting to ignore DNS handling for remote plex.direct hosts (default: on)
  • Core: Fix startup issue with manual servers (introduced with previous beta17)

Edit: If you really want to test it, delete the <hosts> section from your advancedsettings.xml and restart Kodi

Edit 2: This potentially reduces the amount of plex.direct hosts we manage, massively, as well as the amount of times advancedsettings.xml is touched

2 Likes
2596

I know my “most betas just work”-track-record hasn’t been particularly great in the last few betas, but please stick with me, we’re solving a good amount of issues! You’re the ones making this possible by participating!

7 Likes
2597

I’ll say this: It would be easier if the betas would be in a repo :stuck_out_tongue:

5 Likes
2598

Beta 17 working just fine for me. I made the suggested deletion from advancedsettings.xml.

1 Like
2599

Same here: working fine but I also had already previously made the suggested deletion from advancedsettings.xml .

2600

[quote=“panni, post:2595, topic:481208”]
0.7.9-beta17

Renamed the advancedsettings.xml and rebooted the player.
after selecting the home use it takes a while it complains the first time there is no server

2024-08-04 14:18:28.135 T:3998    error <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                                   Error Type: <class 'AttributeError'>
                                                   Error Contents: 'NoneType' object has no attribute 'uuid'
                                                   Traceback (most recent call last):
                                                     File "/storage/.kodi/addons/script.plexmod/lib/windows/kodigui.py", line 144, in onInit
                                                       self._onInit()
                                                     File "/storage/.kodi/addons/script.plexmod/lib/windows/kodigui.py", line 209, in _onInit
                                                       self.onFirstInit()
                                                     File "/storage/.kodi/addons/script.plexmod/lib/windows/home.py", line 476, in onFirstInit
                                                       if self.serverRefresh():
                                                          ^^^^^^^^^^^^^^^^^^^^
                                                     File "/storage/.kodi/addons/script.plexmod/lib/windows/busy.py", line 52, in inner
                                                       return func(*args, **kwargs)
                                                              ^^^^^^^^^^^^^^^^^^^^^
                                                     File "/storage/.kodi/addons/script.plexmod/lib/windows/home.py", line 1086, in serverRefresh
                                                       self.loadLibrarySettings()
                                                     File "/storage/.kodi/addons/script.plexmod/lib/windows/home.py", line 593, in loadLibrarySettings
                                                       setting_key = 'home.settings.{}.{}'.format(plexapp.SERVERMANAGER.selectedServer.uuid[-8:], plexapp.ACCOUNT.ID)
                                                                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                                   AttributeError: 'NoneType' object has no attribute 'uuid'
                                                   -->End of Python script error report<--

exited out PM4K and restarted kodi and it seems to work and it sees the plex server

`

2601

This looks like something that happened before beta17 as well. Can you check?

2602

Which version do you want me to check ?

script.plexmod-0.7.9-beta13.1.zip
script.plexmod-0.7.9-beta13.2.zip
script.plexmod-0.7.9-beta13.3.zip
script.plexmod-0.7.9-beta13.zip
script.plexmod-0.7.9-beta14.zip
script.plexmod0.7.9-beta16.2.zip
script.plexmod-0.7.9-beta16.5.zip
script.plexmod-0.7.9-beta16.6.zip
script.plexmod-0.7.9-beta16.zip
script.plexmod-0.7.9-beta17.zip

And I presume you mean when I delete/rename the advancedsettings.xml

2603

Any one before beta17, just to make sure I didn’t introduce that behavior with that version.

2604

When I switch to 16.6,

  • Restart Kodi
  • Select my home user.
    I get a popup with the message

1 unhandled plex.direct connections found

2605

That’s expected. And switching over to beta17 again reproduces the same error?

2606

Yes, it does.

2607

0.7.9-beta18: script.plexmod.zip (2.8 MB)

Temporary Changelog:

  • Core/Player: Harden resume/seekOnStart for problematic Kodi variants (CoreELEC) (thanks @evertonmdz for sticking with me through the night and about 10 tries)
  • Core/DNS: Don’t throw away old stored servers without the dnsRebindingProtection attribute

This should finally fix the issues with resuming on CoreELEC. Somehow it doesn’t always honor the seek command. We now force it to, basically. It wasn’t easy, as I don’t have CE.

8 Likes