PrimaryFilterActivated condition does not seem to be working

Hello,

ever since OpenPHT 1.5 version, (as a skinner) it seems I’m unable to target filtered episodes (recently added, recently aired etc … )

I’ve checked whether its working with default skin and it isn’t either and I’m re-using same code as default skin in 1.52.

<visible>[Container.PlexContent(Episodes) + IsEmpty(Container.Property(PlexPreplay))] + !IsEmpty(Container.Property(primaryFilterActivated))</visible>

It seems like (Container.Property(primaryFilterActivated)) is not being taken into account.

Background:
As a skinner you can 3 layouts for episodes in PHT:

  1. Season Episode list ( Container.PlexContent(Episodes) + !IsEmpty(Container.Property(PlexPreplay)) )
  2. All Season Episode list (Same as above with !IsEmpty(Container.Property(mixedParents)) )
  3. Filtered Episode list ( [Container.PlexContent(Episodes) + IsEmpty(Container.Property(PlexPreplay))] + !IsEmpty(Container.Property(primaryFilterActivated)) ) —> This one is not working

With OpenPHT only first two are working. PHT all 3 are working.

Any idea how I can target Filtered Episodes in new OpenPHT ? I’d like to create different layout for filteredEpisodes than the one I’m using for regular list.

Thanks

With the refactoring of filters that went into the 1.5.0 release some container properties got changed (most properties did not clean up nicely if the same window got opened for another path with same content type).
Container.Property(PlexFilter) should only have a value if a filter is selected, hopefully that property should work better then primaryFilterActivated.

In the refactoring commit I did replace most condition with only a check for PlexFilter, see https://github.com/RasPlex/OpenPHT/commit/84217c022beabe981a9f8690b3d7b875f591d173#diff-4c52dc3705a138a56ad3dd0593ffb2d8 to simplify the condition, but cannot remember exactly why primaryFilterActivated is behaving differently.

Thanks a million for your response
I will give it a shot tonight and report back.

PS.
I see you quoted LeftSide.xml on github that uses PlexFilter.
In ViewsMovieTV.xml (line 194 & 199) primaryFilterActivated is still being used.

@Kwiboo said:
With the refactoring of filters that went into the 1.5.0 release some container properties got changed (most properties did not clean up nicely if the same window got opened for another path with same content type).
Container.Property(PlexFilter) should only have a value if a filter is selected, hopefully that property should work better then primaryFilterActivated.

In the refactoring commit I did replace most condition with only a check for PlexFilter, see Refactor filters · RasPlex/OpenPHT@84217c0 · GitHub to simplify the condition, but cannot remember exactly why primaryFilterActivated is behaving differently.

Unfortunately it’s not working. It’s actually not working in the default skin either.
Container.Property(PlexFilter) returns same list with or without any filter set. I dont think that’s the problem though.

Include “LibraryFilteredEpisodes” (panel id=“62”) in ViewsMovieTV.xml is not being used at all.
Please see - any changes made to"LibraryFilteredEpisodes" do not take effect.

LibraryFilteredEpisodes” (panel id"62") used to be used to skin the filtered episodes in poster view - now it seems no matter what visibility I set to panel 62 - it won’t work.

Btw - At the moment I’m trying to make default skin work and see how to get panel 62 displaying instead of default Episode view (panel 61) and that’s not working. Once i figure out how to make it work in default skin, I can port it over to my skin.

Thanks

I did a quick check earlier and it is the PlexPreplay property that is behaving differently, see https://github.com/RasPlex/OpenPHT/commit/b371928ab16fb8120fc1b6bb66c53998e3262683 for a fix in the default skin.
It makes the filtered episodes view available when a ‘episodes’-filter is selected and not available under a season preplay view.

OK cool thanks.

But in that case, I had to change PlexPreplay visibility as well. ( I think you will have to as well)

<visible>Container.PlexContent(Episodes) + !IsEmpty(Container.Property(PlexPreplay)) + IsEmpty(Container.Property(primaryFilterActivated))</visible>

otherwise there will be conflict.