Awesome, waiting for one more CPM A14 tester, then I’ll release the skin.
4 Likes
Do you have someone texting it? Or do you need one more? I haven’t tried it yet, but I’m on CPM14 and could install it this evening.
At first glance, I noticed an issue displaying the subtitle language in PlayerProcessInfo when compared to the previous Plextuary CPM skin, but from what I can tell the same issue is present in the v4.0.0 release of Estuary CPM as well.
Seen with internal English SRT and PGS subtitles in MKV files so far.
Will tag @jamal2367 as well - not sure if he’s the original author or not.
I’ll have a look when I get home. 
@fizzmissile
Yes, i’m the original author.
Do not be confused.
1 Like
I can see a change in A14 vs. A8 with regards to subtitle display:
A8:
<visible>VideoPlayer.SubtitlesEnabled</visible>
<visible>VideoPlayer.HasSubtitles</visible>
A14:
<visible>VideoPlayer.SubtitlesEnabled</visible>
So a visible condition is gone, together with what seems like a variable/complexity rewrite. Here’s a version with the old subtitle state from A8: skin.plextuary - 1.zip (7.9 MB)
Does that fix that? Might also completely break it, visually.
Edit: It’ll probably completely break it visually, but is the data correct now?
1 Like
Yep - Does show the data. Internal English PGS subtitle with MKV file, same file as the previous screenshots:
And this one? This just adds the visible condition: skin.plextuary - 2.zip (7.9 MB)
This one uses a combination of both and unifies the style with the audio section: skin.plextuary - 3.zip (7.9 MB)
OK then it’s a data issue. Variant 3 uses the subtitle data from A8 in the new style of A14.
1 Like
Great, thanks for testing. I’ll keep the additional visible check, even though it might not be necessary, and the data approach from A8.
Pushing skin to repo soon.
4 Likes
No problem, thanks for working on it! 
Pushed skin.plextuarycpm: 4.0.0-pm4k1.3cpm.a14 to don’t panic repository
@jamal2367 here are the changes made for the subtitle display, maybe you want to backport those: Fix subtitle display issue with A14 · pannal/skin.plextuary@06c01a2 · GitHub
6 Likes
I see it on my end - Uninstalled the test version and pulled from the repository. Thanks panni!
Thank you!
I will add it to all my modified skins.
Pushed A14.2, forgot to backport something.
6 Likes
One small tidbit I’ll mention after doing a bit more poking around - The previous version (and v4.0.0 of Estuary CPM) appears to display the “Name” tag from a subtitle in the “Subtitle language” area:
This information is no longer shown in the fixed version, which makes sense.
That said, it would be a useful feature to have an option to display this information if present, as it often denotes things like SDH, Forced, Commentary, etc. that may be written in the “Name” tag of a subtitle file. Maybe something for you to consider in a future version @jamal2367
You can always see this information when selecting a subtitle in PM4K, but thought it would be worth mentioning.
It might not have been set in that past example, which lead to it not being displayed. I can simply add it I guess.
Something like this? skin.plextuary - 4.zip (7.9 MB)
Edit: Before the fix, only $INFO[VideoPlayer.SubtitlesName] was being used. My fix uses [UPPERCASE]$INFO[VideoPlayer.SubtitlesLanguage][/UPPERCASE] | $INFO[VideoPlayer.SubtitlesLangEx], this test version uses: [UPPERCASE]$INFO[VideoPlayer.SubtitlesLanguage][/UPPERCASE] | $INFO[VideoPlayer.SubtitlesLangEx]$INFO[VideoPlayer.SubtitlesName, (,)], which optionally displays the name if set in braces.
Edit 2: And I added scrolling to that label, if it exceeds its width.
1 Like
