Adding Cinemascope View-Mode

Hello together,



i’ve been digging and poking around Plex since a couple of days. I’d like to do a constant vertical stretch of all video material.



I’ve added a new Constant to Settings.h:



#define VIEW_MODE_NORMAL 0



#define VIEW_MODE_CINEMASCOPE 6

#define VIEW_MODE_CUSTOM 7




And added a new else if to LinuxRendererGL.cpp with the same Name. It alters:



*g_stSettings.m_fZoomAmount

and

g_stSettings.m_fPixelRatio



What I’d like to achieve is:

**

If the desired View Mode is VIEW_MODE_CINEMASCOPE, do

set the image height to fScreenHeight

set the image width to fScreenHeight
Source-Ratio (dunno which variable it is)



**

I tried setting random values first, but my settings are not applied to the picture.



I also added the GUI-Stuff in GUIDialogVideoSettings:

  • const int entries = {630, 631, 632, 633, 634, 635, 636, 40300 };

    AddSpin(VIDEO_SETTINGS_VIEW_MODE, 629, &g_stSettings.m_currentVideoSettings.m_ViewMode, 8, entries);

    *

    and added my 40300 to strings.xml (asked elan if this range is okay, so no prob there I hope).





    Could you please give me a hint, where else to look and what else to do to get my settings applied? I’d say it’s some minor thing (stupid me then), or I’m not seeing a framework that has to be altered too.



    Thank you in advance :slight_smile:



    Greets

Solved.

Can you please post exactly what files and what the final resolution was? I also have Scope and would love this to work.



Thanks.



These are changes to the Plex source code. To get this working, you'll need to be able to build your own version of Plex first.

I’m sorry to reply this slow.



I added the support to my own fork, as Elan suggested. Then I issued a pull request and had mail contact with him (he has been very patient) and explained, why this view mode would be nice to have. But still, it’s not in 0.7.14 :frowning:



I could post my build here if you want to try and “debug” it, BUT: It’s really that kind of small change that I til now didn’t think it’ll need a build :slight_smile:



EDIT: Currently I’m trying to get sinc and lanczos scaling back in (just for fun though). Bet it’ll make a difference for anamorphic setups.



Greets

I had two different methods of adding this view-mode. I now issued a pull request for the method where it replaced the 4:3 Stretch view mode which should be less hassle for Elan.

Thanks for your patience, we’ll get the feature in, been trying to hard to stabilize :slight_smile:

That’ll rock, elan!



My Scope setup is nearly finished and what cool would it be to simply download Plex and have it working out of the box :slight_smile:



Greets

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.